Nb1X/BepInEx
1
0 Fork 0
mirror of https://github.com/BepInEx/BepInEx.git synced 2026-10-20 01:46:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Prevent skipping plugin on unresolved soft dependency

Browse Source 
Rebase of 4311115
This commit is contained in:
Bepis committed 2020-11-06 02:25:46 +11:00
1 parent 98335942b5
commit df841d04dd
1 file changed
+6 -3
Download Patch File Download Diff File Expand all files Collapse all files
BepInEx.Core/Bootstrap/BaseChainloader.cs
+6 -3
View File
@@ -162,18 +162,21 @@ namespace BepInEx.Bootstrap
var missingDependencies = new List<BepInDependency>();
foreach (var dependency in plugin.Dependencies)
{
bool IsHardDependency(BepInDependency dep)
=> (dep.Flags & BepInDependency.DependencyFlags.HardDependency) != 0;
// If the dependency wasn't already processed, it's missing altogether
bool dependencyExists = processedPlugins.TryGetValue(dependency.DependencyGUID, out var pluginVersion);
if (!dependencyExists || pluginVersion < dependency.MinimumVersion)
{
// If the dependency is hard, collect it into a list to show
if ((dependency.Flags & BepInDependency.DependencyFlags.HardDependency) != 0)
if (IsHardDependency(dependency))
missingDependencies.Add(dependency);
continue;
}
// If the dependency is invalid (e.g. has missing dependencies), report that to the user
if (invalidPlugins.Contains(dependency.DependencyGUID))
// If the dependency is a hard and is invalid (e.g. has missing dependencies), report that to the user
if (invalidPlugins.Contains(dependency.DependencyGUID) && IsHardDependency(dependency))
{
dependsOnInvalidPlugin = true;
break;