Prevent skipping plugin on unresolved soft dependency; fixes #126

This commit is contained in:
ghorsington committed 2020-07-23 10:21:40 +03:00
1 parent 743223e5d1
commit 4311115788
1 file changed
+5 -3
+5 -3
View File
@@ -321,18 +321,20 @@ namespace BepInEx.Bootstrap
var missingDependencies = new List<BepInDependency>();
foreach (var dependency in pluginInfo.Dependencies)
{
bool IsHardDependency(BepInDependency dep) => (dep.Flags & BepInDependency.DependencyFlags.HardDependency) != 0;
// If the dependency wasn't already processed, it's missing altogether
bool dependencyExists = processedPlugins.TryGetValue(dependency.DependencyGUID, out var pluginVersion);
if (!dependencyExists || pluginVersion < dependency.MinimumVersion)
{
// If the dependency is hard, collect it into a list to show
if ((dependency.Flags & BepInDependency.DependencyFlags.HardDependency) != 0)
if (IsHardDependency(dependency))
missingDependencies.Add(dependency);
continue;
}
// If the dependency is invalid (e.g. has missing dependencies), report that to the user
if (invalidPlugins.Contains(dependency.DependencyGUID))
// If the dependency is invalid (e.g. has missing dependencies) and hard, report that to the user
if (invalidPlugins.Contains(dependency.DependencyGUID) && IsHardDependency(dependency))
{
dependsOnInvalidPlugin = true;
break;