remove unnecessary icustomrole methods

MiraAPI.Example/ExampleEventHandlers.cs

@@ -38,12 +38,9 @@ public static class ExampleEventHandlers
     [RegisterEvent]
     public static void StartMeetingEvent(StartMeetingEvent _)
     {
-        foreach (var plr in PlayerControl.AllPlayerControls)
+        foreach (var plr in PlayerControl.AllPlayerControls.ToArray().Where(player => player.Data.Role is MayorRole))
         {
-            if (plr.Data.Role is MayorRole)
-            {
-                plr.GetVoteData().IncreaseRemainingVotes(1);
-            }
+            plr.GetVoteData().IncreaseRemainingVotes(1);
         }
     }
 

MiraAPI/GameOptions/OptionTypes/ModdedOption.cs

@@ -79,17 +79,7 @@ public abstract class ModdedOption<T> : IModdedOption
     /// <summary>
     /// Gets or sets the config definition of the option.
     /// </summary>
-    public ConfigDefinition? ConfigDefinition
-    {
-        get => _configDefinition;
-        set
-        {
-            if (_configDefinition is not null) return;
-            _configDefinition = value;
-        }
-    }
-
-    private ConfigDefinition? _configDefinition;
+    public ConfigDefinition? ConfigDefinition { get; set; }
 
     /// <summary>
     /// Initializes a new instance of the <see cref="ModdedOption{T}"/> class.

MiraAPI/Patches/Options/LobbyViewPanePatches.cs

@@ -250,14 +250,9 @@ public static class LobbyViewPanePatches
 
         var list = new List<Type>();
 
-        var roleGroups = GameSettingMenuPatches.SelectedMod?.CustomRoles.Values.OfType<ICustomRole>()
+        var roleGroups = SelectedMod.CustomRoles.Values.OfType<ICustomRole>()
             .ToLookup(x => x.RoleOptionsGroup);
 
-        if (roleGroups is null)
-        {
-            return;
-        }
-
         // sort the groups by priority
         var sortedRoleGroups = roleGroups
             .OrderBy(x => x.Key.Priority)

MiraAPI/Patches/PlayerControlPatches.cs

@@ -99,11 +99,6 @@ public static class PlayerControlPatches
     [HarmonyPatch(nameof(PlayerControl.FixedUpdate))]
     public static void PlayerControlFixedUpdatePostfix(PlayerControl __instance)
     {
-        if (__instance.Data?.Role is ICustomRole customRole)
-        {
-            customRole.PlayerControlFixedUpdate(__instance);
-        }
-
         if (!__instance.AmOwner)
         {
             return;

MiraAPI/Patches/Roles/HudManagerPatches.cs

@@ -5,29 +5,15 @@ using Reactor.Utilities.Extensions;
 
 namespace MiraAPI.Patches.Roles;
 
-/// <summary>
-/// HudManager patches for roles.
-/// </summary>
 [HarmonyPatch(typeof(HudManager))]
-public static class HudManagerPatches
+internal static class HudManagerPatches
 {
-    // Custom role tab.
     private static TaskPanelBehaviour? _roleTab;
 
-    /// <summary>
-    /// Fixes Kill Button not showing for Neutral killing role.
-    /// </summary>
-    /// <param name="__instance">HudManager instance.</param>
-    /// <param name="localPlayer">The local PlayerControl.</param>
-    /// <param name="role">The player's RoleBehaviour.</param>
-    /// <param name="isActive">Whether the Hud should be set active or not.</param>
     [HarmonyPostfix]
     [HarmonyPatch(nameof(HudManager.SetHudActive), typeof(PlayerControl), typeof(RoleBehaviour), typeof(bool))]
-    public static void SetHudActivePostfix(
-        HudManager __instance,
-        PlayerControl localPlayer,
-        RoleBehaviour role,
-        bool isActive)
+    // ReSharper disable once InconsistentNaming
+    public static void SetHudActivePostfix(HudManager __instance, PlayerControl localPlayer, RoleBehaviour role, bool isActive)
     {
         var flag = localPlayer.Data != null && localPlayer.Data.IsDead;
 
@@ -44,11 +30,9 @@ public static class HudManagerPatches
         }
     }
 
-    /// <summary>
-    /// Update custom role tab and custom role hud elements.
-    /// </summary>
     [HarmonyPostfix]
     [HarmonyPatch(nameof(HudManager.Update))]
+    // ReSharper disable once InconsistentNaming
     public static void UpdatePostfix(HudManager __instance)
     {
         var local = PlayerControl.LocalPlayer;
@@ -62,8 +46,6 @@ public static class HudManagerPatches
 
         if (role is ICustomRole { Configuration.RoleHintType: RoleHintType.RoleTab } customRole)
         {
-            customRole.HudUpdate(__instance);
-
             if (_roleTab == null)
             {
                 _roleTab = CustomRoleManager.CreateRoleTab(customRole);
@@ -71,9 +53,9 @@ public static class HudManagerPatches
 
             CustomRoleManager.UpdateRoleTab(_roleTab, customRole);
         }
-        else if (_roleTab)
+        else if (_roleTab != null)
         {
-            _roleTab?.gameObject.Destroy();
+            _roleTab.gameObject.Destroy();
         }
     }
 }

MiraAPI/Roles/ICustomRole.cs

@@ -74,14 +74,6 @@ public interface ICustomRole : IOptionable
     /// </summary>
     MiraPluginInfo ParentMod => CustomRoleManager.FindParentMod(this);
 
-    /// <summary>
-    /// This method runs on the PlayerControl.FixedUpdate method for ALL players with this role.
-    /// </summary>
-    /// <param name="playerControl">The PlayerControl that has this role.</param>
-    void PlayerControlFixedUpdate(PlayerControl playerControl)
-    {
-    }
-
     internal ConfigDefinition NumConfigDefinition => new("Roles", $"Num {GetType().FullName}");
     internal ConfigDefinition ChanceConfigDefinition => new("Roles", $"Chance {GetType().FullName}");
 
@@ -184,14 +176,6 @@ public interface ICustomRole : IOptionable
         return true;
     }
 
-    /// <summary>
-    /// This method runs on the HudManager.Update method ONLY when the LOCAL player has this role.
-    /// </summary>
-    /// <param name="hudManager">Reference to HudManager instance.</param>
-    void HudUpdate(HudManager hudManager)
-    {
-    }
-
     /// <summary>
     /// Gets a custom ejection message for the role. Return null to use the default message.
     /// </summary>

MiraAPI/Utilities/Extensions.cs

@@ -283,12 +283,13 @@ public static class Extensions
 
             if (count + length > chunkSize)
             {
-                chunks.Enqueue(current.ToArray());
+                chunks.Enqueue([.. current]);
                 current.Clear();
                 count = 0;
             }
 
             current.Add(netData);
+            count += length;
         }
 
         if (current.Count > 0)