fix VERY stupid issue with LobbyViewPanePatches.cs

fix incorrect chunking algorithm
update example
2026-10-20 01:46:15 +00:00 · 2025-03-24 18:57:06 -04:00 · 2025-03-23 15:15:21 -04:00 · 2025-03-23 14:00:12 -04:00 · 2025-03-21 15:24:48 -04:00
4 changed files with 6 additions and 23 deletions
@@ -38,12 +38,9 @@ public static class ExampleEventHandlers
    [RegisterEvent]
    public static void StartMeetingEvent(StartMeetingEvent _)
    {
-        foreach (var plr in PlayerControl.AllPlayerControls)
+        foreach (var plr in PlayerControl.AllPlayerControls.ToArray().Where(player => player.Data.Role is MayorRole))
        {
-            if (plr.Data.Role is MayorRole)
-            {
-                plr.GetVoteData().IncreaseRemainingVotes(1);
-            }
+            plr.GetVoteData().IncreaseRemainingVotes(1);
        }
    }

@@ -79,17 +79,7 @@ public abstract class ModdedOption<T> : IModdedOption
    /// <summary>
    /// Gets or sets the config definition of the option.
    /// </summary>
-    public ConfigDefinition? ConfigDefinition
-    {
-        get => _configDefinition;
-        set
-        {
-            if (_configDefinition is not null) return;
-            _configDefinition = value;
-        }
-    }
-
-    private ConfigDefinition? _configDefinition;
+    public ConfigDefinition? ConfigDefinition { get; set; }

    /// <summary>
    /// Initializes a new instance of the <see cref="ModdedOption{T}"/> class.
@@ -250,14 +250,9 @@ public static class LobbyViewPanePatches

        var list = new List<Type>();

-        var roleGroups = GameSettingMenuPatches.SelectedMod?.CustomRoles.Values.OfType<ICustomRole>()
+        var roleGroups = SelectedMod.CustomRoles.Values.OfType<ICustomRole>()
            .ToLookup(x => x.RoleOptionsGroup);

-        if (roleGroups is null)
-        {
-            return;
-        }
-
        // sort the groups by priority
        var sortedRoleGroups = roleGroups
            .OrderBy(x => x.Key.Priority)
@@ -283,12 +283,13 @@ public static class Extensions

            if (count + length > chunkSize)
            {
-                chunks.Enqueue(current.ToArray());
+                chunks.Enqueue([.. current]);
                current.Clear();
                count = 0;
            }

            current.Add(netData);
+            count += length;
        }

        if (current.Count > 0)
Author	SHA1	Message	Date
XtraCube	bb0b678747	fix VERY stupid issue with LobbyViewPanePatches.cs	2025-03-24 18:57:06 -04:00
XtraCube	f48143610c	fix incorrect chunking algorithm	2025-03-23 15:15:21 -04:00
XtraCube	2cfc5ac039	update example	2025-03-23 14:00:12 -04:00
XtraCube	e9beb3b423	fix weird behaviour	2025-03-21 15:24:48 -04:00