From c5a4858d17470ced423a7513d9a3417bee818127 Mon Sep 17 00:00:00 2001 From: D1GQ Date: Sun, 12 Apr 2026 20:22:33 -0500 Subject: [PATCH] clean up --- src/Data/Json/OutfitData.cs | 29 +++++++++++------------ src/Managers/NetworkManager.cs | 2 +- src/Patches/Gameplay/UI/PlayerTabPatch.cs | 4 ++-- 3 files changed, 17 insertions(+), 18 deletions(-) diff --git a/src/Data/Json/OutfitData.cs b/src/Data/Json/OutfitData.cs index 8df153b..0c314ab 100644 --- a/src/Data/Json/OutfitData.cs +++ b/src/Data/Json/OutfitData.cs @@ -37,7 +37,7 @@ internal sealed class OutfitData /// Gets the outfit data for the currently selected preset. /// /// The outfit data for the current preset. - internal static OutfitData GetOutfitData() => + internal static OutfitData GetCurrentOutfitData() => BetterDataManager.Files.BetterDataFile.OutfitData.ElementAt(BetterDataManager.Files.BetterDataFile.SelectedOutfitPreset); /// @@ -45,7 +45,7 @@ internal sealed class OutfitData /// /// The index of the preset to retrieve. /// The outfit data for the specified preset. - internal static OutfitData GetOutfitData(int index) => + internal static OutfitData GetOutfitDataAt(int index) => BetterDataManager.Files.BetterDataFile.OutfitData.ElementAt(index); private static bool ignoreChange; @@ -55,14 +55,14 @@ internal sealed class OutfitData /// internal static void Initialize() { - FindPreset(); + FindCurrentPreset(); var Save = () => { if (ignoreChange) return; - GetOutfitData().SetFromData(); + GetCurrentOutfitData().UpdateFromCustomizationData(); BetterDataManager.Files.BetterDataFile.Save(); }; @@ -77,12 +77,12 @@ internal sealed class OutfitData /// /// Finds the preset that matches the current player customization and sets it as selected. /// - internal static void FindPreset() + internal static void FindCurrentPreset() { - var collection = BetterDataManager.Files.BetterDataFile.OutfitData; - int i = 0; - foreach (var data in collection) + var allOutfitData = BetterDataManager.Files.BetterDataFile.OutfitData; + for (int i = 0; i < allOutfitData.Count; i++) { + var data = allOutfitData.ElementAt(i); if (data.HatId == DataManager.Player.Customization.Hat && data.PetId == DataManager.Player.Customization.Pet && data.SkinId == DataManager.Player.Customization.Skin && @@ -92,7 +92,6 @@ internal sealed class OutfitData BetterDataManager.Files.BetterDataFile.SelectedOutfitPreset = i; return; } - i++; } BetterDataManager.Files.BetterDataFile.SelectedOutfitPreset = 0; @@ -101,7 +100,7 @@ internal sealed class OutfitData /// /// Validates the outfit data by ensuring all IDs correspond to unlocked items. /// - private void Validate() + private void ValidateOutfit() { if (!HatManager.Instance.GetUnlockedHats().Any(item => item.ProductId == HatId)) HatId = HatData.EmptyId; @@ -116,12 +115,12 @@ internal sealed class OutfitData } /// - /// Loads the outfit data into the player's customization and invokes a callback. + /// Applies the outfit data to the player's customization, invoking a callback after loading. /// /// The callback to invoke after loading the outfit. - internal void Load(Action callback) + internal void ApplyToCustomizationData(Action callback) { - Validate(); + ValidateOutfit(); ignoreChange = true; DataManager.Player.Customization.Hat = HatId; @@ -136,9 +135,9 @@ internal sealed class OutfitData } /// - /// Updates the outfit data with the current player customization values. + /// Updates the outfit data from the player's current customization. /// - internal void SetFromData() + internal void UpdateFromCustomizationData() { HatId = DataManager.Player.Customization.Hat; PetId = DataManager.Player.Customization.Pet; diff --git a/src/Managers/NetworkManager.cs b/src/Managers/NetworkManager.cs index e8b8b43..86b2b5a 100644 --- a/src/Managers/NetworkManager.cs +++ b/src/Managers/NetworkManager.cs @@ -23,7 +23,7 @@ internal static class NetworkManager /// /// Gets the InnerNetClient instance from AmongUsClient. /// - internal static InnerNetClient? InnerNetClient => AmongUsClient.Instance; + internal static InnerNetClient InnerNetClient => AmongUsClient.Instance; /// /// Sends a message to the game server. diff --git a/src/Patches/Gameplay/UI/PlayerTabPatch.cs b/src/Patches/Gameplay/UI/PlayerTabPatch.cs index 44f967e..b9bc79c 100644 --- a/src/Patches/Gameplay/UI/PlayerTabPatch.cs +++ b/src/Patches/Gameplay/UI/PlayerTabPatch.cs @@ -49,7 +49,7 @@ internal static class PlayerTabPatch { int currentI = i; var name = currentI == 0 ? "Among Us Preset" : $"Preset {i}"; - var data = OutfitData.GetOutfitData(currentI); + var data = OutfitData.GetOutfitDataAt(currentI); var button = playerTab.CreateOutfitPresetButton(name, new Vector3(2.5f, 1.55f - currentI * 0.45f, 0f), out var playerPreview, () => { if (BetterDataManager.Files.BetterDataFile.SelectedOutfitPreset == currentI) @@ -72,7 +72,7 @@ internal static class PlayerTabPatch } // Load and apply outfit from preset - data.Load(() => + data.ApplyToCustomizationData(() => { if (LoadPlayerOutfit(data)) {